Pin and test Poetry version #6
Merged
+13
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Poetry has introduced a number of problematic changes recently. To help buffer against these problematic changes, this commit will implement installation and testing of specific versions of Poetry, rather than the latest version. The following steps will be taken to install Poetry and verify that the correct version is installed: 1. Set the `PIPX_VERSION` and `POETRY_VERSION` environment variables, which will be used to install specific versions of each package 2. Install `pipx` with `pip`, for the appropriate version of Python: `pipx` is included by default in the GitHub Actions virtual environment, but only for the default Python version, not necessarily the version installed by actions/setup-python 3. Install Poetry with `pipx`, instead of the get-poetry.py or install-poetry.py install scripts 4. Run a shell test to assert that the Poetry version returned by the `poetry -V` command matches `POETRY_VERSION`
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/br3ndonland/fastenv/4Szn8LCBdmf7i6XJzjfSHE664Uqn |
Codecov Report
@@ Coverage Diff @@
## develop #6 +/- ##
========================================
Coverage 100.0% 100.0%
========================================
Files 3 3
Lines 122 122
========================================
Hits 122 122
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
br3ndonland
added a commit
to br3ndonland/template-python
that referenced
this pull request
Oct 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Poetry has introduced a number of problematic changes recently. To help buffer against these problematic changes, this PR will implement installation and testing of specific versions of Poetry, rather than the latest version.
Changes
The following steps will be taken to install Poetry and verify that the correct version is installed:
PIPX_VERSIONandPOETRY_VERSIONenvironment variables, which will be used to install specific versions of each packagepipxwithpip, for the appropriate version of Python (pipxis included by default in the GitHub Actions virtual environment, but only for the default Python version, not necessarily the version installed by actions/setup-python)pipx, instead of the get-poetry.py and install-poetry.py install scriptspoetry -Vcommand matchesPOETRY_VERSIONRelated
Add Python 3.10 support inboard#36
Pin and test Poetry version inboard#44
Consider strictly following SemVer python-poetry/poetry#4271
Huge number of bugs for a patch release version 1.1.8 - reconsider how releases are versioned python-poetry/poetry#4429
I have reviewed the Guidelines for Contributing and the Code of Conduct.